ref(Dockerfile): ditch the pip cache for a slightly smaller image#1051
ref(Dockerfile): ditch the pip cache for a slightly smaller image#1051helgi merged 1 commit intodeis:masterfrom
Conversation
|
@krancour, @bacongobbler and @mboersma are potential reviewers of this pull request based on my analysis of |
| rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* /usr/share/man /usr/share/doc | ||
| curl -sSL https://bootstrap.pypa.io/get-pip.py | python - pip==8.1.2 && \ | ||
| mkdir -p /configs && chown -R deis:deis /configs && \ | ||
| pip install --disable-pip-version-check --no-cache-dir -r /app/requirements.txt && \ |
There was a problem hiding this comment.
Doesn't --no-cache-dir already do this?
There was a problem hiding this comment.
You'd think but if you drop onto the controller container and dh -h (or similar) that dir, it has data. Can you try it on yours just to confirm?
|
Also considering removing pip itself |
|
Removing pip makes sense. Any reason not to? |
|
Mostly if we are extending main to dev would be a reason to keep it but that's about it! |
Current coverage is 86.87% (diff: 100%)@@ master #1051 diff @@
==========================================
Files 42 42
Lines 3565 3565
Methods 0 0
Messages 0 0
Branches 607 607
==========================================
Hits 3097 3097
Misses 309 309
Partials 159 159
|
|
LGTM, but we should probably investigate why this is neccessary (maybe open an issue?). Could it be that |
5 participants
No description provided.